fix workflow(lint) settings#90
Conversation
- Yellostone uses commander@13.1.0 and it expects node version ">=18", but lint workflow runs on node 14.21.3 - Update all actions to LTS version - Recent commits updated package-lock.json but workflow uses yarn.lock, delete yarn.lock.
- fix lint errors(unused variables)
- fix lint error to use const variables for never changed variables
|
thank you for the pull request. |
|
Hi @GyeongHoKim So the lint fix for using an Underscore is great. Thank you |
|
There is a problem with the lint change for using Underscore as a prefix on unused variables. I think there are two places I need to make changes and and RTSPClient also has some methods that start with Underscore. I'll have a look. Roger |
- remove underscore prefixes from variable names - use private keyword instead of underscore prefixes for methods
f123ed9 to
6d48a28
Compare
Reproduce
All recent failures of Github actions: lint.yml
Reason
Yellowstone uses commander@13.1.0 which expects node version ">=18", but lint workflow runs on Node 14.21.3
Also, there are many files that does not follow eslint rules.
What I did